Skip to content

fix test of affine_grid with rocm#32047

Merged
qili93 merged 2 commits intoPaddlePaddle:developfrom
Ray2020BD:rocm_post_fixop
Apr 6, 2021
Merged

fix test of affine_grid with rocm#32047
qili93 merged 2 commits intoPaddlePaddle:developfrom
Ray2020BD:rocm_post_fixop

Conversation

@Ray2020BD
Copy link
Contributor

@Ray2020BD Ray2020BD commented Apr 2, 2021

PR types

Bug fixes

PR changes

APIs

Describe

fix test of affine_grid with rocm

image

@paddle-bot-old
Copy link

paddle-bot-old bot commented Apr 2, 2021

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

self.dynamic_shape = True
self.use_cudnn = True
if paddle.fluid.core.is_compiled_with_rocm():
self.use_cudnn = False # Current cudnn is not supported in this op with rocm
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

注释改成 # ROCM platform do not have MIOPEN kernel for affine_grid

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@qili93
Copy link
Contributor

qili93 commented Apr 2, 2021

affine_grid API的use_cudnn也需要根据判断是否是rocm平台来关掉use_cudnn

@qili93
Copy link
Contributor

qili93 commented Apr 2, 2021

@Ray2020BD 贴一下rocm环境下这两个单测的结果
test_affine_grid_op
test_affine_grid_function

@Ray2020BD
Copy link
Contributor Author

@Ray2020BD 贴一下rocm环境下这两个单测的结果
test_affine_grid_op
test_affine_grid_function

done.

Copy link
Contributor

@qili93 qili93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@zhiqiu zhiqiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qili93 qili93 merged commit 78af100 into PaddlePaddle:develop Apr 6, 2021
@Ray2020BD Ray2020BD deleted the rocm_post_fixop branch April 7, 2021 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants